From 1be27eca58921d51e6b311687e86b39cf6ee1659 Mon Sep 17 00:00:00 2001
From: Jake Wheat <jakewheatmail@gmail.com>
Date: Thu, 19 Dec 2013 10:34:32 +0200
Subject: [PATCH] rename Duplicates -> SetQuantifier + qeDuplicates ->
 qeSetQuantifier

---
 Language/SQL/SimpleSQL/Parser.lhs             |  2 +-
 Language/SQL/SimpleSQL/Pretty.lhs             |  4 ++--
 Language/SQL/SimpleSQL/Syntax.lhs             | 19 +++++++++++++------
 .../SQL/SimpleSQL/QueryExprComponents.lhs     |  8 +++++++-
 4 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/Language/SQL/SimpleSQL/Parser.lhs b/Language/SQL/SimpleSQL/Parser.lhs
index c8b9088..d18752b 100644
--- a/Language/SQL/SimpleSQL/Parser.lhs
+++ b/Language/SQL/SimpleSQL/Parser.lhs
@@ -158,7 +158,7 @@ aggregate([all|distinct] args [order by orderitems])
 >     makeApp i (Nothing,es,Nothing) = App i es
 >     makeApp i (d,es,od) = AggregateApp i d es (fromMaybe [] od)
 
-> duplicates :: P (Maybe Duplicates)
+> duplicates :: P (Maybe SetQuantifier)
 > duplicates = optionMaybe $ try $
 >     choice [All <$ keyword_ "all"
 >            ,Distinct <$ keyword "distinct"]
diff --git a/Language/SQL/SimpleSQL/Pretty.lhs b/Language/SQL/SimpleSQL/Pretty.lhs
index b48e0b5..c0e86b2 100644
--- a/Language/SQL/SimpleSQL/Pretty.lhs
+++ b/Language/SQL/SimpleSQL/Pretty.lhs
@@ -87,8 +87,8 @@
 > scalarExpr (SpecialOp nm es) =
 >   name nm <+> parens (commaSep $ map scalarExpr es)
 
-> scalarExpr (SpecialOpK (Name nm) fs as) =
->     text nm <> parens (sep $ catMaybes
+> scalarExpr (SpecialOpK nm fs as) =
+>     name nm <> parens (sep $ catMaybes
 >         ((fmap scalarExpr fs)
 >          : map (\(n,e) -> Just (text n <+> scalarExpr e)) as))
 
diff --git a/Language/SQL/SimpleSQL/Syntax.lhs b/Language/SQL/SimpleSQL/Syntax.lhs
index 8cfeef2..d461896 100644
--- a/Language/SQL/SimpleSQL/Syntax.lhs
+++ b/Language/SQL/SimpleSQL/Syntax.lhs
@@ -5,7 +5,7 @@
 >      ScalarExpr(..)
 >     ,Name(..)
 >     ,TypeName(..)
->     ,Duplicates(..)
+>     ,SetQuantifier(..)
 >     ,SortSpec(..)
 >     ,Direction(..)
 >     ,NullsOrder(..)
@@ -65,7 +65,7 @@
 >       -- order by, to regular function application
 >     | AggregateApp
 >       {aggName :: Name -- ^ aggregate function name
->       ,aggDistinct :: Maybe Duplicates -- ^ distinct
+>       ,aggDistinct :: Maybe SetQuantifier -- ^ distinct
 >       ,aggArgs :: [ScalarExpr]-- ^ args
 >       ,aggOrderBy :: [SortSpec] -- ^ order by
 >       }
@@ -192,9 +192,16 @@
 > --    t'.
 > data QueryExpr
 >     = Select
->       {qeDuplicates :: Duplicates
+>       {qeSetQuantifier :: SetQuantifier
 >       ,qeSelectList :: [(Maybe Name,ScalarExpr)]
 >        -- ^ the column aliases and the expressions
+
+TODO: consider breaking this up. The SQL grammar has
+queryexpr = select <select list> [<table expression>]
+table expression = <from> [where] [groupby] [having] ...
+
+This would make some things a bit cleaner?
+
 >       ,qeFrom :: [TableRef]
 >       ,qeWhere :: Maybe ScalarExpr
 >       ,qeGroupBy :: [GroupingExpr]
@@ -206,7 +213,7 @@
 >     | CombineQueryExpr
 >       {qe0 :: QueryExpr
 >       ,qeCombOp :: CombineOp
->       ,qeDuplicates :: Duplicates
+>       ,qeSetQuantifier :: SetQuantifier
 >       ,qeCorresponding :: Corresponding
 >       ,qe1 :: QueryExpr
 >       }
@@ -225,7 +232,7 @@ I'm not sure if this is valid syntax or not.
 > -- | Helper/'default' value for query exprs to make creating query
 > -- expr values a little easier.
 > makeSelect :: QueryExpr
-> makeSelect = Select {qeDuplicates = All
+> makeSelect = Select {qeSetQuantifier = All
 >                     ,qeSelectList = []
 >                     ,qeFrom = []
 >                     ,qeWhere = Nothing
@@ -239,7 +246,7 @@ I'm not sure if this is valid syntax or not.
 > -- | Represents the Distinct or All keywords, which can be used
 > -- before a select list, in an aggregate/window function
 > -- application, or in a query expression set operator.
-> data Duplicates = Distinct | All deriving (Eq,Show,Read)
+> data SetQuantifier = Distinct | All deriving (Eq,Show,Read)
 
 > -- | The direction for a column in order by.
 > data Direction = Asc | Desc deriving (Eq,Show,Read)
diff --git a/tools/Language/SQL/SimpleSQL/QueryExprComponents.lhs b/tools/Language/SQL/SimpleSQL/QueryExprComponents.lhs
index 1d8f42b..c209cd1 100644
--- a/tools/Language/SQL/SimpleSQL/QueryExprComponents.lhs
+++ b/tools/Language/SQL/SimpleSQL/QueryExprComponents.lhs
@@ -36,7 +36,7 @@ These are a few misc tests which don't fit anywhere else.
 >     ]
 >  where
 >    ms d = makeSelect
->           {qeDuplicates = d
+>           {qeSetQuantifier = d
 >           ,qeSelectList = [(Nothing,Iden "a")]
 >           ,qeFrom = [TRSimple "t"]}
 
@@ -64,6 +64,12 @@ These are a few misc tests which don't fit anywhere else.
 >     ,("select a a, b b"
 >      ,makeSelect {qeSelectList = [(Just "a", Iden "a")
 >                                  ,(Just "b", Iden "b")]})
+
+>     ,("select a + b * c"
+>      ,makeSelect {qeSelectList =
+>       [(Nothing,BinOp (Iden (Name "a")) (Name "+")
+>        (BinOp (Iden (Name "b")) (Name "*") (Iden (Name "c"))))]})
+
 >     ]
 
 > whereClause :: TestItem