1
Fork 0

rename qeFetch to qeFetchFirst

This commit is contained in:
Jake Wheat 2013-12-19 17:50:25 +02:00
parent a231c7e9f8
commit 40c64c7631
4 changed files with 40 additions and 5 deletions

View file

@ -38,9 +38,37 @@ because the parser applies the fixity fix to every 'top level' value
expr, we don't need to descend into query exprs to find the value
exprs inside them.
start creating test list
start creating test list:
create tests with an explicit fixity table to check the features of
the fixity code, then create tests for sql value expressions which
sanity check the fixity applied to these expressions.
basic fixity tests:
a + b + c
a + b * c
a * b + c
a + b + c * d
a * b + c + d
try also with right assocative
a HI b PostfixLow
a low b PostfixHigh
a LOWEST b HI c PostfixMEDIUM
+ variations
same with prefix
same with chained binops
----
now sanity check the basic operators (these use BinOp, PrefixOp,
PostfixOp) then sanity check all the other operators which take part
in the fixity
> {-# LANGUAGE TupleSections #-}

View file

@ -211,7 +211,7 @@ This would make some things a bit cleaner?
> ,qeHaving :: Maybe ValueExpr
> ,qeOrderBy :: [SortSpec]
> ,qeOffset :: Maybe ValueExpr
> ,qeFetch :: Maybe ValueExpr
> ,qeFetchFirst :: Maybe ValueExpr
> }
> | CombineQueryExpr
> {qe0 :: QueryExpr
@ -244,7 +244,7 @@ I'm not sure if this is valid syntax or not.
> -- > ,qeHaving = Nothing
> -- > ,qeOrderBy = []
> -- > ,qeOffset = Nothing
> -- > ,qeFetch = Nothing}
> -- > ,qeFetchFirst = Nothing}
> makeSelect :: QueryExpr
> makeSelect = Select {qeSetQuantifier = All
@ -255,7 +255,7 @@ I'm not sure if this is valid syntax or not.
> ,qeHaving = Nothing
> ,qeOrderBy = []
> ,qeOffset = Nothing
> ,qeFetch = Nothing}
> ,qeFetchFirst = Nothing}
> -- | Represents the Distinct or All keywords, which can be used

7
TODO
View file

@ -5,6 +5,11 @@ check fixity in query expr level?
check fixity in tablerefs
try and use the proper css theme
create a header like in the haddock with simple-sql-parser +
contents link
change the toc gen so that it works the same as in haddock (same
div, no links on the actual titles
fix the page margins, and the table stuff: patches to the css?
release checklist:
hlint
@ -92,6 +97,8 @@ a collation in ansi sql is a optional qualifier plus identifier, not a
string
have to do fixity for this to work
see what schema.fun(a) parses to and decide if this is correct
all ansi string literal syntax?
check ansi standard for operators (keywords and symbols)

View file

@ -138,7 +138,7 @@ These are a few misc tests which don't fit anywhere else.
> {qeSelectList = [(Nothing,Iden "a")]
> ,qeFrom = [TRSimple "t"]
> ,qeOffset = o
> ,qeFetch = l}
> ,qeFetchFirst = l}
> combos :: TestItem
> combos = Group "combos" $ map (uncurry TestQueryExpr)